fix(verifier): resolve CodeQL no-effect Protocol stub#46
Merged
Conversation
VerifierStrategy.verify used `...` as its body, which CodeQL flags as py/ineffectual-statement and which also diverged from the existing FindingVerifier Protocol house style. Use a docstring body instead, and drop the now-redundant quoted forward reference (UP037, future annotations). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates src/security_scanner/core/evaluation/verifier_harness.py by adding a docstring to the verify method of the VerifierStrategy protocol and removing the string quotes from the RecordedVerifierStrategy return type annotation in the from_file classmethod. There are no review comments, so no feedback is provided.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
#45 머지 직전 들어온 CodeQL code-scanning 알림(
py/ineffectual-statement, alert #32)을 후속으로 해소한다.무엇을
VerifierStrategyProtocol의verify가 본문으로...(Ellipsis 표현식)을 써서 CodeQL이 "Statement has no effect"로 플래그했고, 기존FindingVerifierProtocol(runtime/verify_artifact.py)의 docstring 본문 관례와도 어긋났다.def verify(...): ...→ docstring 본문("""Return a verifier result for one finding.""")으로 교체, 하우스 스타일과 일치.-> "RecordedVerifierStrategy"→-> RecordedVerifierStrategy, UP037,from __future__ import annotations하에 안전).검증
uv run pytest753 passed,ruff checkAll checks passed.🤖 Generated with Claude Code